script to add users

Hi I have to add a lot of users to sql server with datareader access I have
created the script below but this does not work do you know what I would hav
e
to cahnge to get it working?
thanks for any help
Sammy
DECLARE @.user varchar (8)
DECLARE @.SQLString NVARCHAR(500)
DECLARE @.pwd NVARCHAR(8)
DECLARE @.db NVARCHAR(10)
SET @.SQLString =
N'EXEC sp_addlogin ''@.user'', ''@.pwd'', ''@.db''
use ''@.db''
EXEC sp_grantdbaccess ''@.user'',''@.user''
EXEC sp_addrolemember ''db_datareader'',''@.user''
'
SET @.user = 'clairep'
set @.pwd = 'london'
set @.db= 'pubs'Try this
DECLARE @.user varchar (8)
DECLARE @.SQLString NVARCHAR(500)
DECLARE @.pwd NVARCHAR(8)
DECLARE @.db NVARCHAR(10)
SET @.user = 'clairep'
set @.pwd = 'london'
set @.db= 'pubs'
SET @.SQLString = 'EXEC sp_addlogin ' + @.user + ', ' + @.pwd + ', ' + @.db
SET @.SQLString = @.SQLString + ' USE ' + @.db
SET @.SQLString = @.SQLString + ' EXEC sp_grantdbaccess ' + @.user + ', ' + @.us
er
SET @.SQLString = @.SQLString + ' EXEC sp_addrolemember db_datareader, ' + @.us
er
EXEC (@.SQLString)
Andy
"Sammy" wrote:

> Hi I have to add a lot of users to sql server with datareader access I hav
e
> created the script below but this does not work do you know what I would h
ave
> to cahnge to get it working?
> thanks for any help
> Sammy
>
> DECLARE @.user varchar (8)
> DECLARE @.SQLString NVARCHAR(500)
> DECLARE @.pwd NVARCHAR(8)
> DECLARE @.db NVARCHAR(10)
>
> SET @.SQLString =
> N'EXEC sp_addlogin ''@.user'', ''@.pwd'', ''@.db''
> use ''@.db''
> EXEC sp_grantdbaccess ''@.user'',''@.user''
> EXEC sp_addrolemember ''db_datareader'',''@.user''
> '
> SET @.user = 'clairep'
> set @.pwd = 'london'
> set @.db= 'pubs'|||Try,
DECLARE @.user varchar (8)
DECLARE @.SQLString NVARCHAR(500)
DECLARE @.pwd NVARCHAR(8)
DECLARE @.db NVARCHAR(10)
SET @.user = N'clairep'
set @.pwd = N'london'
set @.db= N'pubs'
SET @.SQLString = N'use master' + char(13)
SET @.SQLString = @.SQLString + N'EXEC sp_addlogin ''' + @.user + N''', ''' +
@.pwd + N''', ''' + @.db + N'''' + char(13)
SET @.SQLString = @.SQLString + N'use ' + quotename(@.db) + char(13)
SET @.SQLString = @.SQLString + N'EXEC sp_grantdbaccess ''' + @.user + N''','''
+ @.user + N'''' + char(13)
SET @.SQLString = @.SQLString + N'EXEC sp_addrolemember ''db_datareader'','''
+ @.user + N''''
execute sp_executesql @.SQLString
go
AMB
"Sammy" wrote:

> Hi I have to add a lot of users to sql server with datareader access I hav
e
> created the script below but this does not work do you know what I would h
ave
> to cahnge to get it working?
> thanks for any help
> Sammy
>
> DECLARE @.user varchar (8)
> DECLARE @.SQLString NVARCHAR(500)
> DECLARE @.pwd NVARCHAR(8)
> DECLARE @.db NVARCHAR(10)
>
> SET @.SQLString =
> N'EXEC sp_addlogin ''@.user'', ''@.pwd'', ''@.db''
> use ''@.db''
> EXEC sp_grantdbaccess ''@.user'',''@.user''
> EXEC sp_addrolemember ''db_datareader'',''@.user''
> '
> SET @.user = 'clairep'
> set @.pwd = 'london'
> set @.db= 'pubs'